Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password in integration test #6284

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix password in integration test #6284

merged 1 commit into from
Dec 1, 2024

Conversation

akstron
Copy link
Contributor

@akstron akstron commented Dec 1, 2024 •
edited
Loading

Which problem is this PR solving?

Minor fix in cassandra initialization for integration test

Description of the changes

  • Changed environment variable used for initialization

Checklist

@akstron
fixing pswd in integration test
5838310 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron akstron requested a review from a team as a code owner December 1, 2024 04:51
@akstron akstron requested a review from pavolloffay December 1, 2024 04:51
@dosubot dosubot bot added the area/storage label Dec 1, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (39e3bfb) to head (5838310).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6284      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.03%     
==========================================
  Files         356      356              
  Lines       20416    20416              
==========================================
- Hits        19642    19637       -5     
- Misses        585      589       +4     
- Partials      189      190       +1
Flag Coverage Δ
badger_v1 8.90% <ø> (ø)
badger_v2 1.63% <ø> (ø)
cassandra-4.x-v1-manual 14.84% <ø> (ø)
cassandra-4.x-v2-auto 1.57% <ø> (ø)
cassandra-4.x-v2-manual 1.57% <ø> (ø)
cassandra-5.x-v1-manual 14.84% <ø> (ø)
cassandra-5.x-v2-auto 1.57% <ø> (ø)
cassandra-5.x-v2-manual 1.57% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (ø)
elasticsearch-7.x-v1 18.67% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.62% <ø> (-0.01%) ⬇️
grpc_v1 10.37% <ø> (ø)
grpc_v2 7.91% <ø> (+<0.01%) ⬆️
kafka-v1 8.58% <ø> (ø)
kafka-v2 1.63% <ø> (ø)
memory_v2 1.63% <ø> (ø)
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.63% <ø> (ø)
tailsampling-processor 0.45% <ø> (ø)
unittests 95.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

good catch

@yurishkuro yurishkuro enabled auto-merge (squash) December 1, 2024 14:54
@yurishkuro yurishkuro disabled auto-merge December 1, 2024 14:54
@yurishkuro yurishkuro changed the title Fixing password in integration test Fix password in integration test Dec 1, 2024
@yurishkuro yurishkuro merged commit 05d4c4e into jaegertracing:main Dec 1, 2024
54 of 56 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akstron @yurishkuro